ci: add support for crash dumps from sanity pipeline#319498
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
@dmitrivMSMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for collecting Electron crash dumps from sanity test runs (desktop and WSL) and publishing them as pipeline artifacts. A new --crash-dumps-dir CLI option is plumbed through index.ts / main.ts / TestContext, used by the desktop and WSL test setups to pass --crash-reporter-directory to the launched VS Code, and the Azure Pipelines job creates the directory, forwards the path to the run scripts, and conditionally publishes a crash-dumps-* artifact.
Changes:
- New
--crash-dumps-dir/-doption in the sanity test CLI andTestContext, with agetCrashDumpsDir()helper that returns a per-test, sanitized subdirectory. desktop.test.tsandwsl.test.tsappend--crash-reporter-directory <dir>to VS Code launch args when a crash dumps dir is provided.- Azure pipeline (
sanity-tests.yml) createsCRASH_DUMPS_DIR, forwards-d/--crash-dumps-dirto all platform/docker run scripts, setsHAS_CRASH_DUMPS, and publishes a crash-dumps pipeline artifact.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/index.ts | Adds the --crash-dumps-dir/-d CLI option and help text. |
| test/sanity/src/main.ts | Parses crash-dumps-dir and forwards it to TestContext. |
| test/sanity/src/context.ts | Stores crashDumpsDir option and exposes getCrashDumpsDir() with a per-test sanitized path. |
| test/sanity/src/desktop.test.ts | Passes --crash-reporter-directory to the launched desktop VS Code. |
| test/sanity/src/wsl.test.ts | Passes --crash-reporter-directory to the launched VS Code for WSL tests. |
| build/azure-pipelines/common/sanity-tests.yml | Creates the crash dumps dir, forwards it to run scripts (incl. docker), detects non-empty output, and publishes a pipeline artifact. |
DonJayamanne
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #318542