Skip to content

ci: add support for crash dumps from sanity pipeline#319498

Merged
deepak1556 merged 2 commits into
mainfrom
robo/debug_sanity_test_crash
Jun 2, 2026
Merged

ci: add support for crash dumps from sanity pipeline#319498
deepak1556 merged 2 commits into
mainfrom
robo/debug_sanity_test_crash

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

For #318542

@deepak1556 deepak1556 added this to the 1.124.0 milestone Jun 2, 2026
@deepak1556 deepak1556 self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 02:11
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering Bot commented Jun 2, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/common/sanity-tests.yml

@dmitrivMS

Matched files:

  • build/azure-pipelines/common/sanity-tests.yml
  • test/sanity/scripts/run-docker.sh
  • test/sanity/src/context.ts
  • test/sanity/src/desktop.test.ts
  • test/sanity/src/index.ts
  • test/sanity/src/main.ts
  • test/sanity/src/wsl.test.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for collecting Electron crash dumps from sanity test runs (desktop and WSL) and publishing them as pipeline artifacts. A new --crash-dumps-dir CLI option is plumbed through index.ts / main.ts / TestContext, used by the desktop and WSL test setups to pass --crash-reporter-directory to the launched VS Code, and the Azure Pipelines job creates the directory, forwards the path to the run scripts, and conditionally publishes a crash-dumps-* artifact.

Changes:

  • New --crash-dumps-dir / -d option in the sanity test CLI and TestContext, with a getCrashDumpsDir() helper that returns a per-test, sanitized subdirectory.
  • desktop.test.ts and wsl.test.ts append --crash-reporter-directory <dir> to VS Code launch args when a crash dumps dir is provided.
  • Azure pipeline (sanity-tests.yml) creates CRASH_DUMPS_DIR, forwards -d/--crash-dumps-dir to all platform/docker run scripts, sets HAS_CRASH_DUMPS, and publishes a crash-dumps pipeline artifact.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/sanity/src/index.ts Adds the --crash-dumps-dir/-d CLI option and help text.
test/sanity/src/main.ts Parses crash-dumps-dir and forwards it to TestContext.
test/sanity/src/context.ts Stores crashDumpsDir option and exposes getCrashDumpsDir() with a per-test sanitized path.
test/sanity/src/desktop.test.ts Passes --crash-reporter-directory to the launched desktop VS Code.
test/sanity/src/wsl.test.ts Passes --crash-reporter-directory to the launched VS Code for WSL tests.
build/azure-pipelines/common/sanity-tests.yml Creates the crash dumps dir, forwards it to run scripts (incl. docker), detects non-empty output, and publishes a pipeline artifact.

@deepak1556 deepak1556 merged commit 18d58f4 into main Jun 2, 2026
54 of 57 checks passed
@deepak1556 deepak1556 deleted the robo/debug_sanity_test_crash branch June 2, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants