Add create folder to simple file dialog#319564
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for creating a new folder from the Simple File Dialog when using a folder-only picker (notably when files.simpleDialog.enable is enabled), addressing the “can’t start a new project” workflow in the Agents Window.
Changes:
- Extends the open (folder-only) validation flow to prompt to create a missing folder when the parent exists and is writable, then creates it via
fileService.createFolder. - Simplifies several async validation returns by using direct
true/falsereturns instead ofPromise.resolve(...).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts | Adds folder-creation prompt + createFolder call for folder-only open validation; simplifies boolean returns in validate. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
ulugbekna
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318768