show harness name instead of 'Overview'#319585
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AI Customization management editor’s sidebar “Overview” (home) button to reflect the active customization harness (icon + label) when the harness selector dropdown is disabled, and documents that behavior for the Sessions window.
Changes:
- Add logic to update the sidebar home button’s icon/label/aria-label based on the active harness when the selector is disabled.
- Trigger the home button presentation update on harness changes and after header creation.
- Document the intended sidebar behavior in
AI_CUSTOMIZATIONS.md.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Updates the sidebar home button presentation based on the active harness. |
| src/vs/sessions/AI_CUSTOMIZATIONS.md | Documents the sidebar behavior when the harness selector dropdown is disabled. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
Comment on lines
632
to
+636
| const homeButton = this.homeButton = DOM.append(headerRow, $('button.sidebar-home-button')); | ||
| homeButton.classList.add('sidebar-harness-home-button'); | ||
| homeButton.setAttribute('aria-label', localize('homeButton', "Overview")); | ||
| this.editorDisposables.add(this.hoverService.setupManagedHover(getDefaultHoverDelegate('element'), homeButton, localize('homeButtonTooltip', "Back to overview"))); | ||
| const homeIcon = DOM.append(homeButton, $('span.sidebar-home-icon')); | ||
| const homeIcon = this.homeButtonIcon = DOM.append(homeButton, $('span.sidebar-home-icon')); |
Comment on lines
+714
to
+728
| const descriptor = this.harnessService.getActiveDescriptor(); | ||
| if (!descriptor) { | ||
| this.homeButtonIcon.className = 'sidebar-home-icon'; | ||
| this.homeButtonIcon.classList.add(...ThemeIcon.asClassNameArray(Codicon.home)); | ||
| this.homeButtonLabel.textContent = localize('overview', "Overview"); | ||
| this.homeButton.setAttribute('aria-label', localize('homeButton', "Overview")); | ||
| this.homeButton.title = localize('homeButtonTooltip', "Back to overview"); | ||
| return; | ||
| } | ||
|
|
||
| this.homeButtonIcon.className = 'sidebar-home-icon'; | ||
| this.homeButtonIcon.classList.add(...ThemeIcon.asClassNameArray(descriptor.icon)); | ||
| this.homeButtonLabel.textContent = descriptor.label; | ||
| this.homeButton.setAttribute('aria-label', localize('homeButtonWithHarness', "{0}, Back to overview", descriptor.label)); | ||
| this.homeButton.title = localize('homeButtonTooltipWithHarness', "Current harness: {0}. Click to go to overview", descriptor.label); |
|
|
||
| The Agents sidebar `AICustomizationShortcutsWidget` supports three entrypoint modes via `sessions.customizations.sidebarMode`: `welcome` (default) keeps the per-category sidebar rows but opens the AI Customization management editor welcome page, `section` restores per-category deep linking, and `single` replaces the per-category rows with one Customizations entry that opens the welcome page. All modes keep the active customization harness in sync with the active session before opening the editor. | ||
|
|
||
| When the harness selector dropdown is disabled in the management editor, the sidebar overview button displays the active harness name and harness icon (matching the picker icon) with a distinct background treatment. |
lszomoru
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.