Skip to content

Copilot AH customizations: support agent instructions#319639

Merged
aeschli merged 4 commits into
mainfrom
aeschli/delightful-mackerel-900
Jun 3, 2026
Merged

Copilot AH customizations: support agent instructions#319639
aeschli merged 4 commits into
mainfrom
aeschli/delightful-mackerel-900

Conversation

@aeschli
Copy link
Copy Markdown
Contributor

@aeschli aeschli commented Jun 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings June 2, 2026 20:12
@aeschli aeschli enabled auto-merge (squash) June 2, 2026 20:12
@aeschli aeschli self-assigned this Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for discovering “agent instruction” markdown files as part of Agent Host customizations, so they can be surfaced to Copilot (as rules) with special handling (e.g. always-apply semantics) while keeping the existing plugin bundling model for agents/skills/instructions.

Changes:

  • Extend SessionCustomizationDiscovery to scan for supported agent-instruction filenames in workspace/user-home locations and adjust watcher setup.
  • Update bundling to exclude agent-instruction discoveries from the synthetic plugin tree.
  • Mark discovered agent-instruction files as Rule children with alwaysApply and add discovery/watcher tests.
Show a summary per file
File Description
src/vs/platform/agentHost/test/node/sessionCustomizationDiscovery.test.ts Adds tests for agent-instruction discovery and watcher expectations.
src/vs/platform/agentHost/node/shared/sessionPluginBundler.ts Skips bundling AgentInstruction discoveries into the plugin layout.
src/vs/platform/agentHost/node/copilot/sessionCustomizationDiscovery.ts Introduces DiscoveredType.AgentInstruction, new instruction filename/root scanning, and refactors watcher registration.
src/vs/platform/agentHost/node/copilot/copilotAgent.ts Treats AgentInstruction as rules and flags them alwaysApply.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 4

Comment thread src/vs/platform/agentHost/node/copilot/sessionCustomizationDiscovery.ts Outdated
Comment on lines 103 to +107
for (const discoveredDirectory of directories) {
const dir = pluginDirForType(discoveredDirectory.type);
if (!dir) {
continue; // do not bundle agent instructions
}
roblourens
roblourens previously approved these changes Jun 3, 2026
aeschli and others added 2 commits June 3, 2026 10:10
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@aeschli aeschli merged commit efc4d0d into main Jun 3, 2026
25 checks passed
@aeschli aeschli deleted the aeschli/delightful-mackerel-900 branch June 3, 2026 10:16
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants