Browser: update suggestions dynamically as tabs change#319654
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes stale “Open Tabs” URL-bar suggestions in the Integrated Browser by making tab suggestions update dynamically when editor groups/tabs change, preventing users from selecting a suggestion that no longer exists (issue #319276).
Changes:
- Refactored URL picker suggestion loading to cache per-provider results and refresh providers independently while the picker is open.
- Added live
onDidChangesignaling for the “Open Tabs” suggestion provider so tab additions/removals/renames and group changes reflow the suggestions list in real time.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts | Reworks picker suggestion rendering to support per-provider refresh and stable re-rendering while the picker is open. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Makes the “Open Tabs” URL suggestion provider emit onDidChange on tab/group/label changes and orders suggestions by group visibility. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
|
My old Google account data recovery |
mjbvz
previously approved these changes
Jun 2, 2026
Yoyokrazy
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319276