cli: support pinning initial agent host version for upgrade testing#319671
Merged
Conversation
- There was no way to exercise the agent host upgrade flow locally, since the CLI always starts the latest server version and has nothing older to upgrade from. - Adds a VSCODE_CLI_INITIAL_AH_VERSION env var that pins the commit the agent host is first downloaded and started at, while leaving subsequent upgrades to resolve the real latest version, so the full download + restart upgrade path can be driven on demand. (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in mechanism to help locally exercise the agent host upgrade path by pinning the initial resolved/downloaded agent host commit (via VSCODE_CLI_INITIAL_AH_VERSION), while allowing later upgrade checks to resolve the real latest version.
Changes:
- Introduces
VSCODE_CLI_INITIAL_AH_VERSIONand helperinitial_agent_host_version(). - Ensures the first version resolution honors the override even when cached server versions exist.
- Caches/logs the override-backed
Releaseon first resolution, then resumes normal “latest” resolution thereafter.
Show a summary per file
| File | Description |
|---|---|
| cli/src/tunnels/agent_host.rs | Adds env-var driven “initial commit” override and adjusts first-resolution logic so upgrade testing can start from an older downloaded agent host. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Addresses PR review: the env var value flows into URL and filesystem paths, so restrict it to hex digits (and trim whitespace) to prevent path separators or traversal sequences.
DonJayamanne
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Commit message generated by Copilot)