Skip to content

Improve skill completion filtering and avoid duplicates in Copilot agent#319854

Merged
DonJayamanne merged 8 commits into
mainfrom
don/convenient-chinchilla
Jun 4, 2026
Merged

Improve skill completion filtering and avoid duplicates in Copilot agent#319854
DonJayamanne merged 8 commits into
mainfrom
don/convenient-chinchilla

Conversation

@DonJayamanne
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 4, 2026 06:15
@DonJayamanne DonJayamanne self-assigned this Jun 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how Copilot agent session configuration is built to reduce duplicated SDK inputs from plugins, and tightens slash-skill completion results to avoid repeated entries.

Changes:

  • Filter plugin-derived agents/skills/hooks/MCP servers so directory-backed plugins rely on SDK discovery rather than being double-fed.
  • Deduplicate skill slash completions by skill URI while matching the user’s typed prefix.
Show a summary per file
File Description
src/vs/platform/agentHost/node/copilot/copilotAgent.ts Updates session config construction to avoid feeding resources from directory-backed plugins (reducing duplication risk).
src/vs/platform/agentHost/node/agentHostSkillCompletionProvider.ts Adds dedupe logic for skill slash completions and keeps prefix filtering.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread src/vs/platform/agentHost/node/copilot/copilotAgent.ts
Comment thread src/vs/platform/agentHost/node/agentHostSkillCompletionProvider.ts
@DonJayamanne DonJayamanne marked this pull request as ready for review June 4, 2026 07:57
@DonJayamanne DonJayamanne enabled auto-merge (squash) June 4, 2026 07:57
dmitrivMS
dmitrivMS previously approved these changes Jun 4, 2026
@DonJayamanne
Copy link
Copy Markdown
Contributor Author

had to resolve a merge conflict

auto-merge was automatically disabled June 4, 2026 16:00

Pull request was closed

@DonJayamanne DonJayamanne reopened this Jun 4, 2026
@DonJayamanne DonJayamanne enabled auto-merge (squash) June 4, 2026 16:00
@DonJayamanne DonJayamanne merged commit eb9cd86 into main Jun 4, 2026
25 checks passed
@DonJayamanne DonJayamanne deleted the don/convenient-chinchilla branch June 4, 2026 16:31
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants