Skip to content

AgentHost - use git-blob only for the file content#319901

Merged
lszomoru merged 3 commits into
mainfrom
lszomoru/optimistic-wolf
Jun 4, 2026
Merged

AgentHost - use git-blob only for the file content#319901
lszomoru merged 3 commits into
mainfrom
lszomoru/optimistic-wolf

Conversation

@lszomoru
Copy link
Copy Markdown
Member

@lszomoru lszomoru commented Jun 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings June 4, 2026 11:47
@lszomoru lszomoru enabled auto-merge (squash) June 4, 2026 11:47
@lszomoru lszomoru self-assigned this Jun 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agent Host git-diff parsing logic (parseGitDiffRawNumstat) to build ISessionFileDiff objects where git-blob: URIs are used for file content references, while the before.uri/after.uri fields represent the working-tree file: URIs for the paths.

Changes:

  • Refactors diff mapping to compute before, after, and diff as named locals and return them as a single object.
  • Changes after.uri (when afterRef is provided) to be a working-tree file: URI rather than a git-blob: URI, while keeping after.content.uri anchored to afterRef.
Show a summary per file
File Description
src/vs/platform/agentHost/node/agentHostGitService.ts Adjusts parseGitDiffRawNumstat output shape and how after URIs are constructed, aiming to restrict git-blob: usage to content references.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread src/vs/platform/agentHost/node/agentHostGitService.ts Outdated
Comment thread src/vs/platform/agentHost/node/agentHostGitService.ts
@lszomoru lszomoru merged commit f5cefba into main Jun 4, 2026
25 checks passed
@lszomoru lszomoru deleted the lszomoru/optimistic-wolf branch June 4, 2026 14:02
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants