Telemetry improvements - Better internal check#319936
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines Copilot/chat-related telemetry by reducing potentially confusing quota data and improving how internal-user context is represented in common telemetry properties, in support of #318611.
Changes:
- Widen
ITelemetryService.setCommonProperty(and implementations) to acceptbooleanin addition tostring. - Remove
quotaChat(chat percent-remaining) from thechatInstallEntitlementtelemetry payload/classification. - Populate
common.msftInternalas a common property based onChatEntitlementService.isInternalwhen the telemetry service wasn’t already flagged internal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/telemetry/electron-browser/telemetryService.ts | Propagates setCommonProperty type widening to desktop workbench telemetry wrapper. |
| src/vs/workbench/services/telemetry/browser/telemetryService.ts | Propagates setCommonProperty type widening to web workbench telemetry wrapper. |
| src/vs/workbench/services/chat/common/chatEntitlementService.ts | Removes quotaChat from chatInstallEntitlement telemetry event and its GDPR typing. |
| src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts | Sets common telemetry properties from chat entitlement state (tracking ID + internal flag). |
| src/vs/platform/telemetry/common/telemetryService.ts | Allows boolean common properties to be stored by the core telemetry service. |
| src/vs/platform/telemetry/common/telemetry.ts | Updates the ITelemetryService contract to allow boolean common properties. |
| src/vs/platform/dataChannel/browser/forwardingTelemetryService.ts | Updates forwarding telemetry wrapper to match the new setCommonProperty signature. |
| src/vs/platform/agentHost/node/agentHostTelemetryService.ts | Updates agent host telemetry wrapper to match the new setCommonProperty signature. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #318611