Fix Ctrl+Tab/Ctrl+Shift+Tab session navigation in Agents window#319937
Merged
ulugbekna merged 1 commit intoJun 4, 2026
Merged
Conversation
The `sessions.goBack`/`sessions.goForward` actions registered Ctrl+Shift+Tab and Ctrl+Tab as secondary keybindings at `WorkbenchContrib` the sameweight chords and weight as the editor quick-open actions. With equal weight the editor actions won the conflict in the Agents window, so the chords never triggered session navigation. Bump the weight to `WorkbenchContrib + 1` so the session bindings win. The the Agents window, leaving the main workbench Ctrl+Tab behavior untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes session navigation in the Agents window so Ctrl+Tab / Ctrl+Shift+Tab correctly move forward/back between sessions instead of being shadowed by the workbench editor quick-open bindings.
Changes:
- Increase the keybinding weight for
sessions.goBack/sessions.goForwardso theirCtrl+Shift+Tab/Ctrl+Tabsecondary bindings win over the editor quick-open actions at the same chord/weight. - Add inline comments documenting why the higher weight is required (to avoid the workbench conflict).
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/sessionsActions.ts | Raises keybinding weight for session back/forward actions to resolve Ctrl+Tab chord conflicts in the Agents window. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
benvillalobos
approved these changes
Jun 4, 2026
ulugbekna
deleted the
agents/what-are-the-default-keybindings-for-agent-windo-972b98d0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ctrl+Tab/Ctrl+Shift+Tabdid not navigate forward/back between sessions in the Agents window.Root cause
The
sessions.goBack/sessions.goForwardactions registerCtrl+Shift+TabandCtrl+Tabas secondary keybindings at weightKeybindingWeight. the same chords and same weight as the workbench editor quick-open actions:WorkbenchContribCtrl+TabCtrl+Shift+TabWith equal weight, the resolver tiebreaks by command name;
workbench.action.*sorts aftersessions.*, so the editor actions were evaluated first and won the conflict in the Agents window. The session chords therefore never fired.Fix
Higher-weight bindings on these chords (
quickOpenNavigate*InEditorPicker,quickInputBackatWorkbenchContrib + 50) are gated on active picker contexts and intentionally still win while a picker is open.cc @sandy081
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com