Skip to content

Implement inline session title editing functionality#319940

Merged
benibenj merged 6 commits into
mainfrom
benibenj/agents/session-title-editing-feature
Jun 4, 2026
Merged

Implement inline session title editing functionality#319940
benibenj merged 6 commits into
mainfrom
benibenj/agents/session-title-editing-feature

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

@benibenj benibenj commented Jun 4, 2026

Copilot Generated Description: Introduce functionality for inline editing of session titles, allowing users to rename sessions directly within the interface. This includes the necessary UI elements and event handling for starting and committing edits.

Copilot AI review requested due to automatic review settings June 4, 2026 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds inline session title editing to the Agents window session header, allowing users to rename a session directly by interacting with the title area, and styles the header to support swapping the rendered title text for an inline <input>.

Changes:

  • Added inline rename UI flow in SessionHeader (swap title text span ↔ input; Enter to commit, Escape/blur to cancel).
  • Prevented session drag initiation while a rename input is active.
  • Updated header/title CSS to support inline input styling and hover affordances for editable titles.
Show a summary per file
File Description
src/vs/sessions/browser/parts/sessionHeader.ts Adds inline title editing logic, editable gating, and drag suppression while editing.
src/vs/sessions/browser/parts/media/chatCompositeBar.css Updates title layout and adds styles for the inline rename input + editable/hover states.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 7

Comment thread src/vs/sessions/browser/parts/sessionHeader.ts Outdated
Comment thread src/vs/sessions/browser/parts/sessionHeader.ts
Comment thread src/vs/sessions/browser/parts/sessionHeader.ts
Comment thread src/vs/sessions/browser/parts/media/chatCompositeBar.css
Comment thread src/vs/sessions/browser/parts/sessionHeader.ts
Comment thread src/vs/sessions/browser/parts/sessionHeader.ts
Comment thread src/vs/sessions/browser/parts/media/chatCompositeBar.css
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Base: d4f23d0b Current: f39afe0a

No screenshot changes.

dmitrivMS
dmitrivMS previously approved these changes Jun 4, 2026
@benibenj benibenj enabled auto-merge (squash) June 4, 2026 16:34
dmitrivMS
dmitrivMS previously approved these changes Jun 4, 2026
sandy081
sandy081 previously approved these changes Jun 4, 2026
dmitrivMS
dmitrivMS previously approved these changes Jun 4, 2026
@benibenj benibenj dismissed stale reviews from dmitrivMS and sandy081 via 83b1e5d June 4, 2026 21:14
@benibenj benibenj merged commit 323248f into main Jun 4, 2026
25 checks passed
@benibenj benibenj deleted the benibenj/agents/session-title-editing-feature branch June 4, 2026 21:36
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants