Bump built-in dompurify#319947
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates VS Code’s vendored DOMPurify copy under src/vs/base/browser/dompurify/ from 3.2.7 to 3.4.8, including runtime JS, TypeScript typings, and the component governance manifest.
Changes:
- Updated
dompurify.jsto DOMPurify 3.4.8 (includes upstream security hardening and new config behaviors). - Updated
dompurify.d.tsto match 3.4.8 types (notably function-basedADD_TAGS/ADD_ATTR, and newADD_FORBID_CONTENTS+TRUSTED_TYPES_POLICY: null). - Updated
cgmanifest.jsonmetadata (tag/commit/version) for the new upstream version.
Show a summary per file
| File | Description |
|---|---|
| src/vs/base/browser/dompurify/dompurify.js | Vendored DOMPurify runtime updated to 3.4.8; includes new Trusted Types and clobbering/template-safety logic. |
| src/vs/base/browser/dompurify/dompurify.d.ts | Typings updated to match 3.4.8 surface area and config options. |
| src/vs/base/browser/dompurify/cgmanifest.json | Updated component governance metadata (commit/tag/version) for DOMPurify 3.4.8. |
Copilot's findings
Files not reviewed (1)
- src/vs/base/browser/dompurify/dompurify.js: Language not supported
- Files reviewed: 1/3 changed files
- Comments generated: 2
Comment on lines
+417
to
+426
| window.DocumentFragment; | ||
| const HTMLTemplateElement = window.HTMLTemplateElement, | ||
| Node = window.Node, | ||
| Element = window.Element, | ||
| NodeFilter = window.NodeFilter, | ||
| _window$NamedNodeMap = window.NamedNodeMap; | ||
| _window$NamedNodeMap === void 0 ? window.NamedNodeMap || window.MozNamedAttrMap : _window$NamedNodeMap; | ||
| window.HTMLFormElement; | ||
| const DOMParser = window.DOMParser, | ||
| trustedTypes = window.trustedTypes; |
| var purify = createDOMPurify(); | ||
|
|
||
| export { purify as default }; | ||
| //# sourceMappingURL=purify.es.mjs.map No newline at end of file |
rzhao271
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.