move more progress parts to shimmer#320020
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how chat tool-invocation progress is visually represented, shifting shimmer styling behavior (including a new “partial shimmer” for askQuestions) and adjusting shimmer eligibility logic across several tool progress parts.
Changes:
- Refines shimmer eligibility via
shouldShimmerForTool(...), focusing shimmer onaskQuestionsinvocation text (and adding partial shimmer styling for the prefix before" ("). - Updates chat progress rendering/CSS to support partial shimmer via a dedicated span (
.chat-progress-shimmer-text) and selector changes. - Expands/updates unit tests to cover the new shimmer rules and plaintext rendering in the markdown renderer mock.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatToolProgressPart.test.ts | Updates tests for new shimmer rules and adds coverage for partial shimmer output. |
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Adjusts shimmer selectors to support partial shimmer spans. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolProgressPart.ts | Computes shimmer per tool/content and wires shimmer + icon behavior into ChatProgressContentPart. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolPartUtilities.ts | Adds isAskQuestionsToolInvocation and changes shimmer decision logic to depend on displayed content. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatSimpleToolProgressPart.ts | Passes displayed message into shimmer decision helper. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatInputOutputMarkdownProgressPart.ts | Passes displayed message into shimmer decision helper. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts | Implements partial shimmer DOM wrapping for askQuestions progress text. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/media/chat.css:3085
- The new shimmer animation runs unconditionally. To respect users’ reduced-motion preferences, disable the shimmer animation under
@media (prefers-reduced-motion: reduce)(similar to other chat animations in this stylesheet).
&.shimmer-progress .rendered-markdown.progress-step:not(.chat-progress-partial-shimmer) > p,
&.shimmer-progress .rendered-markdown.progress-step.chat-progress-partial-shimmer .chat-progress-shimmer-text {
background: linear-gradient(90deg,
var(--vscode-descriptionForeground) 0%,
var(--vscode-descriptionForeground) 30%,
var(--vscode-chat-thinkingShimmer) 50%,
var(--vscode-descriptionForeground) 70%,
var(--vscode-descriptionForeground) 100%);
background-size: 400% 100%;
background-clip: text;
-webkit-background-clip: text;
-webkit-text-fill-color: transparent;
animation: chat-thinking-shimmer 2s linear infinite;
will-change: background-position;
- Files reviewed: 7/7 changed files
- Comments generated: 1
dmitrivMS
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #318585