Skip to content

move more progress parts to shimmer#320020

Merged
justschen merged 1 commit into
mainfrom
justin/salandit
Jun 5, 2026
Merged

move more progress parts to shimmer#320020
justschen merged 1 commit into
mainfrom
justin/salandit

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

fix #318585

Copilot AI review requested due to automatic review settings June 4, 2026 23:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how chat tool-invocation progress is visually represented, shifting shimmer styling behavior (including a new “partial shimmer” for askQuestions) and adjusting shimmer eligibility logic across several tool progress parts.

Changes:

  • Refines shimmer eligibility via shouldShimmerForTool(...), focusing shimmer on askQuestions invocation text (and adding partial shimmer styling for the prefix before " (").
  • Updates chat progress rendering/CSS to support partial shimmer via a dedicated span (.chat-progress-shimmer-text) and selector changes.
  • Expands/updates unit tests to cover the new shimmer rules and plaintext rendering in the markdown renderer mock.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatToolProgressPart.test.ts Updates tests for new shimmer rules and adds coverage for partial shimmer output.
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Adjusts shimmer selectors to support partial shimmer spans.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolProgressPart.ts Computes shimmer per tool/content and wires shimmer + icon behavior into ChatProgressContentPart.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolPartUtilities.ts Adds isAskQuestionsToolInvocation and changes shimmer decision logic to depend on displayed content.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatSimpleToolProgressPart.ts Passes displayed message into shimmer decision helper.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatInputOutputMarkdownProgressPart.ts Passes displayed message into shimmer decision helper.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts Implements partial shimmer DOM wrapping for askQuestions progress text.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/media/chat.css:3085

  • The new shimmer animation runs unconditionally. To respect users’ reduced-motion preferences, disable the shimmer animation under @media (prefers-reduced-motion: reduce) (similar to other chat animations in this stylesheet).
	&.shimmer-progress .rendered-markdown.progress-step:not(.chat-progress-partial-shimmer) > p,
	&.shimmer-progress .rendered-markdown.progress-step.chat-progress-partial-shimmer .chat-progress-shimmer-text {
		background: linear-gradient(90deg,
				var(--vscode-descriptionForeground) 0%,
				var(--vscode-descriptionForeground) 30%,
				var(--vscode-chat-thinkingShimmer) 50%,
				var(--vscode-descriptionForeground) 70%,
				var(--vscode-descriptionForeground) 100%);
		background-size: 400% 100%;
		background-clip: text;
		-webkit-background-clip: text;
		-webkit-text-fill-color: transparent;
		animation: chat-thinking-shimmer 2s linear infinite;
		will-change: background-position;
  • Files reviewed: 7/7 changed files
  • Comments generated: 1

@justschen justschen marked this pull request as ready for review June 5, 2026 00:13
@justschen justschen enabled auto-merge (squash) June 5, 2026 00:15
@justschen justschen merged commit 4046533 into main Jun 5, 2026
26 checks passed
@justschen justschen deleted the justin/salandit branch June 5, 2026 00:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate and update spinners

3 participants