fix: improve connection registration logic in startAgentHost#320032
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts startAgentHost’s utility-process connection handling so that reverse-RPC filesystem authority registration is applied not only to newly added MessagePort connections but also to connections that already exist when the agent host initializes.
Changes:
- Refactors connection→authority registration into a shared
registerConnectionhelper. - Registers the helper for future connections (
onDidAddConnection). - Backfills registration for already-established connections by iterating
server.connectionsat startup.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/agentHostMain.ts | Ensures existing UtilityProcessServer connections get their client filesystem authorities registered at startup, not only on subsequent connection events. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
justschen
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.