Skip to content

Refactor border-radius styles for consistency#320065

Merged
mrleemurray merged 4 commits into
mainfrom
mrleemurray/compatible-rose-penguin
Jun 5, 2026
Merged

Refactor border-radius styles for consistency#320065
mrleemurray merged 4 commits into
mainfrom
mrleemurray/compatible-rose-penguin

Conversation

@mrleemurray
Copy link
Copy Markdown
Contributor

@mrleemurray mrleemurray commented Jun 5, 2026

This pull request standardizes the way border radii are applied across various CSS files in the project. Instead of using hardcoded pixel values for border-radius, the code now uses CSS variables (e.g., --vscode-cornerRadius-small, --vscode-cornerRadius-large). This change improves consistency, makes it easier to update the design system, and enhances themeability across the UI.

The most important changes are:

Core border-radius standardization:

  • Replaced all hardcoded border-radius pixel values in style.css, openInVSCode.css, sidebarActionButton.css, and other component styles with corresponding --vscode-cornerRadius-* CSS variables for consistent theming. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Component-specific updates:

  • Updated border-radius usage in sidebar, panel, auxiliary bar, chat composite bar, and project bar components to use the new variables, ensuring visual consistency across all major UI parts. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Mobile and overlay view adjustments:

  • Applied the same border-radius variable standardization to mobile-specific styles, including overlay views and picker sheets, for a unified look on all devices. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

This refactor makes it much easier to adjust the application's corner styling in the future and ensures that changes propagate consistently throughout the UI.

mrleemurray and others added 3 commits June 5, 2026 09:55
- Updated various CSS files to replace hardcoded border-radius values with corresponding CSS variables for consistency and maintainability.
- Adjusted border-radius for elements in openInVSCode.css, sidebarActionButton.css, style.css, auxiliaryBarPart.css, chatCompositeBar.css, panelPart.css, projectBarPart.css, mobile styles, agentFeedback styles, changes view styles, and more.
- Ensured that all instances of border-radius now utilize the defined variables such as --vscode-cornerRadius-small, --vscode-cornerRadius-medium, --vscode-cornerRadius-large, etc.

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 09:20
@mrleemurray mrleemurray enabled auto-merge (squash) June 5, 2026 09:20
@mrleemurray mrleemurray self-assigned this Jun 5, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering Bot commented Jun 5, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@benibenj

Matched files:

  • src/vs/sessions/browser/parts/media/auxiliaryBarPart.css
  • src/vs/sessions/browser/parts/media/chatCompositeBar.css
  • src/vs/sessions/browser/parts/media/panelPart.css
  • src/vs/sessions/browser/parts/media/projectBarPart.css
  • src/vs/sessions/browser/parts/media/sidebarPart.css
  • src/vs/sessions/browser/parts/media/titlebarpart.css
  • src/vs/sessions/browser/parts/mobile/contributions/media/mobileMultiDiffView.css
  • src/vs/sessions/browser/parts/mobile/contributions/media/mobileOverlayViews.css
  • src/vs/sessions/browser/parts/mobile/media/mobilePickerSheet.css
  • src/vs/sessions/browser/parts/mobile/media/mobileSessionFilterChips.css
  • src/vs/sessions/browser/parts/mobile/media/mobileSortGroupSheet.css
  • src/vs/sessions/browser/parts/mobile/mobileChatShell.css

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors Agents window (src/vs/sessions/**) styling to standardize border-radius usage via the platform corner-radius size tokens (e.g. --vscode-cornerRadius-small/medium/large/xLarge/circle) instead of mixed per-file pixel values.

Changes:

  • Replaced various hardcoded border-radius pixel values with the corresponding --vscode-cornerRadius-* CSS variables across sessions UI components.
  • Updated border radii for multiple Agents window parts (titlebar, sidebar/panel/aux bar, project bar, chat UI, providers, and overlays) to improve consistency and themeability.
  • Applied the same standardization to mobile-specific UI (bottom sheets, overlay views, phone layout widgets).

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/sessions/contrib/tunnelHost/electron-browser/media/tunnelHost.css Use corner-radius token for tunnel host toggle.
src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css Standardize corner radii for compact button and keybinding label.
src/vs/sessions/contrib/sessions/browser/media/sessionsTitleBarWidget.css Standardize unread badge corner radius.
src/vs/sessions/contrib/sessions/browser/media/sessionsList.css Standardize list row, card, and toolbar control corner radii.
src/vs/sessions/contrib/providers/remoteAgentHost/browser/media/hostPickerSheet.css Standardize sheet handle corner radius token.
src/vs/sessions/contrib/providers/remoteAgentHost/browser/media/hostPickerDropdown.css Standardize dropdown handle corner radius token.
src/vs/sessions/contrib/providers/remoteAgentHost/browser/media/hostFilter.css Standardize filter chip and close button corner radii.
src/vs/sessions/contrib/policyBlocked/browser/media/sessionsPolicyBlocked.css Standardize progress bar corner radii.
src/vs/sessions/contrib/chat/browser/media/runScriptAction.css Standardize run-script UI and quick input modal corner radii.
src/vs/sessions/contrib/chat/browser/media/noAgentHostEmptyState.css Standardize inline code pill corner radius.
src/vs/sessions/contrib/chat/browser/media/chatWidget.css Standardize button-like control corner radii.
src/vs/sessions/contrib/chat/browser/media/chatInput.css Standardize chat input container, toolbar buttons, and pills corner radii.
src/vs/sessions/contrib/changes/browser/media/checksWidget.css Standardize checks widget container and row corner radii.
src/vs/sessions/contrib/changes/browser/media/changesViewActions.css Standardize action item corner radius.
src/vs/sessions/contrib/changes/browser/media/changesView.css Standardize action/button and list row corner radii (incl. mixed-corner cases).
src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorWidget.css Standardize editor widget corner radii across sections and pills.
src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorOverlay.css Standardize overlay widget and action corner radii.
src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorInput.css Standardize input widget and input field corner radii.
src/vs/sessions/contrib/accountMenu/browser/media/accountTitleBarWidget.css Standardize badge corner radius.
src/vs/sessions/browser/parts/mobile/mobileChatShell.css Standardize phone layout corner radii (pills, input, buttons).
src/vs/sessions/browser/parts/mobile/media/mobileSortGroupSheet.css Standardize sheet handle corner radius.
src/vs/sessions/browser/parts/mobile/media/mobileSessionFilterChips.css Standardize chip corner radius.
src/vs/sessions/browser/parts/mobile/media/mobilePickerSheet.css Standardize picker sheet handle, search, list item, and icon corner radii.
src/vs/sessions/browser/parts/mobile/contributions/media/mobileOverlayViews.css Standardize overlay view control, pills, and FAB corner radii.
src/vs/sessions/browser/parts/mobile/contributions/media/mobileMultiDiffView.css Standardize multi-diff action corner radius.
src/vs/sessions/browser/parts/media/titlebarpart.css Standardize checked action corner radius.
src/vs/sessions/browser/parts/media/sidebarPart.css Standardize checked sidebar toggle corner radius.
src/vs/sessions/browser/parts/media/projectBarPart.css Standardize project bar focus ring, icons, badges, and indicator corner radii.
src/vs/sessions/browser/parts/media/panelPart.css Standardize panel composite bar label and checked state corner radii.
src/vs/sessions/browser/parts/media/chatCompositeBar.css Standardize chat composite bar controls corner radii.
src/vs/sessions/browser/parts/media/auxiliaryBarPart.css Standardize auxiliary bar composite bar label and checked state corner radii.
src/vs/sessions/browser/media/style.css Add default sessions action-bar corner radius + standardize various container radii.
src/vs/sessions/browser/media/sidebarActionButton.css Standardize sidebar action button corner radius.
src/vs/sessions/browser/media/openInVSCode.css Standardize titlebar “Open in VS Code” control corner radius.

Comment thread src/vs/sessions/browser/parts/mobile/mobileChatShell.css
@mrleemurray mrleemurray merged commit 248c024 into main Jun 5, 2026
25 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/compatible-rose-penguin branch June 5, 2026 10:04
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants