Improve border visibility for key bindings in light/dark themes#320076
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the visibility of keybinding “pill” borders in Quick Input list items for light (.vs) and dark (.vs-dark) themes by avoiding --vscode-widget-shadow (which can be transparent) and instead deriving a subtle border color from the current foreground color. High contrast themes are intentionally unaffected.
Changes:
- Add a light/dark-theme-specific override for keybinding border color in focused/hovered Quick Input list rows.
- Use
color-mix(..., currentColor ..., transparent)to produce a consistent, theme-adaptive border even when widget shadow is transparent.
sandy081
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the visibility of key binding borders in light and dark themes by deriving the border color from the foreground, addressing issues with transparency that made borders invisible against certain backgrounds. High contrast themes remain unaffected.
Addresses: https://github.com/microsoft/vscode-internalbacklog/issues/7676