use nonce when comparing customizations changes#320102
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines how BaseAgentHostSessionsProvider detects session customization changes so that onDidChangeCustomAgents / onDidChangeCustomizations only fire when relevant customization inputs actually change (reducing unnecessary picker recomputation during frequent SessionState updates).
Changes:
- Added a
customizationsChanged(previous, state)helper to centralize customization-diff logic. - Switched the two
SessionStateupdate fan-out paths to use the helper (instead of raw reference comparisons), including nonce-based comparison foractiveClient.customizations.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts | Adds customizationsChanged and uses it to gate customization-change events during session state updates. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+596
to
+601
| return arrayEquals(previousActiveCustomizations, currentActiveCustomizations, (a, b) => { | ||
| if (a.nonce !== undefined && a.nonce === b.nonce) { | ||
| return true; | ||
| } | ||
| return a === b; | ||
| }); |
benibenj
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.