Fix terminal "Rerun Task" closing the task without restarting it

[Copilot]

Description

The terminal "Rerun Task" button terminated the active task but never restarted it.

_restart() awaits TerminalTaskSystem.terminate() before calling run(), but terminate() resolved its promise solely from the terminal's onExit event. When a task terminal is disposed, TerminalInstance._onProcessExit bails out after await this._flushXtermData() (it hits if (this.isDisposed) return), so onExit never fires — only onDisposed does. The terminate promise never settles, _restart() is stuck awaiting it, and the task is closed but never re-run.

Changes in terminalTaskSystem.ts terminate():

• Settle on first event — resolve on whichever of onExit/onDisposed fires first, guarded against double-resolution, so the restart flow always proceeds to run().
• Clear _activeTasks — remove the terminated task from _activeTasks (matching terminateAll()), preventing run() from throwing "There is already a task running" on the stale entry.

const finish = () => {
    if (resolved) { return; }
    resolved = true;
    onExit.dispose();
    onDisposedListener.dispose();
    const terminatedTask = activeTerminal.task;
    if (this._activeTasks[mapKey] === activeTerminal) {
        delete this._activeTasks[mapKey];
    }
    resolve({ success: true, task: terminatedTask });
};
const onDisposedListener = terminal.onDisposed(t => { this._fireTaskEvent(TaskEvent.terminated(task, t.instanceId, t.exitReason)); finish(); });
const onExit = terminal.onExit(() => { /* fire terminated event */ finish(); });
terminal.dispose();

[Copilot]

Pull request overview

Fixes a regression in the task “Rerun Task” flow where terminating a task could dispose the terminal without ever firing onExit, causing TerminalTaskSystem.terminate() to never resolve and preventing the task from being restarted.

Changes:

• Update TerminalTaskSystem.terminate() to resolve termination on the first of onExit or onDisposed.
• Remove the terminated task from _activeTasks during termination to avoid stale “already running” state on rerun.

Show a summary per file

File	Description
src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts	Adjusts task termination to settle on onExit/onDisposed (whichever happens first) and clears _activeTasks so rerun can proceed.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 1