Scope notification.acceptPrimaryAction keybinding to screen reader users#320149
Merged
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cmd+shift+A keybinding conflict for notifications
Scope notification.acceptPrimaryAction keybinding to screen reader users
Jun 5, 2026
meganrogge
approved these changes
Jun 5, 2026
meganrogge
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a keybinding conflict by restricting notification.acceptPrimaryAction (Cmd/Ctrl+Shift+A) to screen reader optimized mode (accessibilityModeEnabled), freeing the shortcut for agents.openVSCodeWindow for non-screen-reader users.
Changes:
- Gate
notification.acceptPrimaryActionkeybinding behindCONTEXT_ACCESSIBILITY_MODE_ENABLEDwhile preserving existing notification focus/toast visibility conditions. - Add the required accessibility context key import in the notifications commands registration file.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/notifications/notificationsCommands.ts | Scopes the notification.acceptPrimaryAction keybinding to accessibilityModeEnabled to avoid Cmd/Ctrl+Shift+A collisions for most users. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
lramos15
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmd+shift+Awas claimed by bothnotification.acceptPrimaryActionandagents.openVSCodeWindow, causing accidental (and dangerous) acceptance of notification primary actions.This scopes
notification.acceptPrimaryActionto screen reader users — its original audience — freeing the binding foragents.openVSCodeWindoweveryone else.notificationsCommands.ts: gate the keybinding behindCONTEXT_ACCESSIBILITY_MODE_ENABLED, AND-combined with the existing focus/toast-visibility conditions:The command remains available via the Command Palette for all users; only the keybinding is now conditional on accessibility mode.