Fix overflow handling in URL bar#320238
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a BrowserView URL bar overflow/ellipsis interaction glitch by adjusting how the URL display behaves while focused and when it loses focus, preventing the visual/selection state from remaining in an inconsistent scrolled/overflowed position.
Changes:
- Reset the URL display’s horizontal scroll position on blur to avoid leaving it scrolled after caret navigation.
- Disable ellipsis rendering while the URL display is focused (switch to
text-overflow: clip) to avoid overflow-related selection artifacts.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts | Resets scrollLeft on blur to snap the URL display back to the start after focus leaves. |
| src/vs/workbench/contrib/browserView/electron-browser/media/browser.css | Changes focused URL display to use text-overflow: clip instead of ellipsis while focused. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
roblourens
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320197