Browser: never focus a URL suggestion by default#320239
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Integrated Browser URL picker’s focus behavior so asynchronously streamed URL suggestions never become the active (focused) item by default, keeping focus on the synchronous default (“Go to …”) entry unless the user explicitly selects a suggestion.
Changes:
- Update URL picker rendering to explicitly control
activeItems, distinguishing between user typing (reset to default) and background provider refreshes (preserve current selection). - Add regression tests covering “no auto-focus on streamed suggestions” and “preserve selection on refresh, reset on typing”.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts | Explicitly manages quick pick active item to prevent async suggestions from stealing focus; preserves selection on background refresh. |
| src/vs/workbench/contrib/browserView/test/electron-browser/widgets/browserUrlBarWidget.test.ts | Adds tests validating the new focus/selection behavior across streaming and refresh scenarios. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+524
to
+525
| const suggestion = picker.items.find((i): i is IQuickPickItem => i.type !== 'separator' && i.id === 'tab-1')!; | ||
| picker.activeItems = [suggestion]; |
roblourens
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.