Skip to content

Fix OSX builds #37564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaomoreno merged 1 commit into from
Nov 6, 2017
+10 −2
Merged

Fix OSX builds #37564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ install:
- ./scripts/npm.sh install

script:
- node_modules/.bin/gulp hygiene --silent
- node_modules/.bin/gulp hygiene
- node_modules/.bin/gulp electron --silent
- node_modules/.bin/gulp compile --silent --max_old_space_size=4096
- node_modules/.bin/gulp optimize-vscode --silent --max_old_space_size=4096
Expand Down
10 changes: 9 additions & 1 deletion build/gulpfile.hygiene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,16 @@ const hygiene = exports.hygiene = (some, options) => {
.pipe(gulpeslint.formatEach('compact'))
.pipe(gulpeslint.failAfterError());

let count = 0;
return es.merge(typescript, javascript)
.pipe(es.through(null, function () {
.pipe(es.through(function (data) {
count++;
if (count % 10 === 0) {
process.stdout.write('.');
}
this.emit('data', data);
}, function () {
process.stdout.write('\n');
if (errorCount > 0) {
this.emit('error', 'Hygiene failed with ' + errorCount + ' errors. Check \'build/gulpfile.hygiene.js\'.');
} else {
Expand Down