Add a function return type for typescript snippets.#39133
Closed
Heatwave wants to merge 1 commit intomicrosoft:masterfrom
Heatwave:master
Closed
Add a function return type for typescript snippets.#39133Heatwave wants to merge 1 commit intomicrosoft:masterfrom Heatwave:master
Heatwave wants to merge 1 commit intomicrosoft:masterfrom
Heatwave:master
Conversation
Collaborator
|
TypeScript can correctly infer the return type in the majority of cases and I'm generally hesitant to add something to snippets that some users would end up deleting. This needs some more feedback. Can you please open an issue so we can gauge interest in this change |
Collaborator
|
Closing until we get more feedback on #39231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it should be a best practice for the TypeScript that to always specify the function return type. So I add this snippet. Thanks.