Skip to content

SelectBox toggle select on 2nd click Fixes: #40513#40547

Merged
cleidigh merged 1 commit intomicrosoft:masterfrom
cleidigh:selectbox-2click/bug
Dec 20, 2017
Merged

SelectBox toggle select on 2nd click Fixes: #40513#40547
cleidigh merged 1 commit intomicrosoft:masterfrom
cleidigh:selectbox-2click/bug

Conversation

@cleidigh
Copy link
Copy Markdown
Contributor

  • Track SelectBox active with _isVisible
  • Toggle select box with each mouseclick

Fixes: #40513

@cleidigh cleidigh requested a review from bpasero December 20, 2017 04:06
@cleidigh cleidigh self-assigned this Dec 20, 2017
@cleidigh cleidigh added this to the December 2017/January 2018 milestone Dec 20, 2017
@cleidigh cleidigh merged commit 94a5b0c into microsoft:master Dec 20, 2017
@cleidigh
Copy link
Copy Markdown
Contributor Author

cleidigh commented Dec 20, 2017

Not sure why there is both a commit and the merge??? I think I needed the second option, squash and merge...

@cleidigh cleidigh deleted the selectbox-2click/bug branch December 20, 2017 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SelectBox doesn't close on second click

1 participant