Skip to content

[monaco] bind ILogService to NullLogService by default #41927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdima merged 1 commit into from
Jan 23, 2018
+3 −0
Merged

[monaco] bind ILogService to NullLogService by default #41927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/vs/editor/standalone/browser/standaloneServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import { ContextKeyService } from 'vs/platform/contextkey/browser/contextKeyServ
import { IMenuService } from 'vs/platform/actions/common/actions';
import { IStandaloneThemeService } from 'vs/editor/standalone/common/standaloneThemeService';
import { StandaloneThemeServiceImpl } from 'vs/editor/standalone/browser/standaloneThemeServiceImpl';
import { ILogService, NullLogService } from 'vs/platform/log/common/log';
Copy link
Copy Markdown

@ghost ghost Jan 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#41586


export interface IEditorContextViewService extends IContextViewService {
dispose(): void;
Expand Down Expand Up @@ -142,6 +143,8 @@ export module StaticServices {

export const storageService = define(IStorageService, () => NullStorageService);

export const logService = define(ILogService, () => new NullLogService());

}

export class DynamicStandaloneServices extends Disposable {
Expand Down