Disallow drag splitting of non-splittable editors#44308
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Feb 26, 2018
Merged
Disallow drag splitting of non-splittable editors#44308bpasero merged 1 commit intomicrosoft:masterfrom
bpasero merged 1 commit intomicrosoft:masterfrom
Conversation
**Problem** Editors use the `supportsSplitEditor` property to enable/disable splitting. Even if splitting is disabled, you can still split an editor by dragging it to create a new copy. **Fix** For non-splittable editors, make dragging always just move the editor to a new group
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Editors use the
supportsSplitEditorproperty to enable/disable splitting. Even if splitting is disabled, you can still split an editor by dragging it to create a new copy of the editorFix
For non-splittable editors, make dragging always just move the editor to the new target group