Skip to content

Prevent natives module from being imported#47507

Closed
Tyriar wants to merge 1 commit intoben/electron-2.0from
tyriar/electron-2.0-native-crash
Closed

Prevent natives module from being imported#47507
Tyriar wants to merge 1 commit intoben/electron-2.0from
tyriar/electron-2.0-native-crash

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Apr 9, 2018

@bpasero bpasero added this to the April 2018 milestone Apr 10, 2018
@bpasero
Copy link
Copy Markdown
Member

bpasero commented Apr 10, 2018

@Tyriar maybe the error message should be a bit more verbose to explain why we cannot require this module?

@alexandrudima can you have a look as loader expert to give 👍 or 👎 on this approach to prevent the natives module from loading in the extension host?

@bpasero bpasero requested a review from alexdima April 10, 2018 05:24
@alexdima
Copy link
Copy Markdown
Member

Wow, you use very cryptic issues. It must be you are using voice chat to communicate...

None of the issues, this one, or any of the linked ones: #47289, #46552, #45542 explain what's wrong with natives. I'm sorry I can't add a helpful review under these circumstances.

@bpasero
Copy link
Copy Markdown
Member

bpasero commented Apr 10, 2018

@Tyriar this is good. I committed a variant of your change that:

@bpasero bpasero closed this Apr 10, 2018
@bpasero bpasero deleted the tyriar/electron-2.0-native-crash branch April 10, 2018 09:37
@Tyriar
Copy link
Copy Markdown
Contributor Author

Tyriar commented Apr 10, 2018

only does it in the extension host process

@bpasero even better 👍

@alexdima
Copy link
Copy Markdown
Member

👍

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants