Prevent natives module from being imported#47507
Closed
Tyriar wants to merge 1 commit intoben/electron-2.0from
Closed
Prevent natives module from being imported#47507Tyriar wants to merge 1 commit intoben/electron-2.0from
Tyriar wants to merge 1 commit intoben/electron-2.0from
Conversation
Member
|
@Tyriar maybe the error message should be a bit more verbose to explain why we cannot require this module? @alexandrudima can you have a look as loader expert to give 👍 or 👎 on this approach to prevent the |
Member
Member
|
@Tyriar this is good. I committed a variant of your change that:
|
Contributor
Author
@bpasero even better 👍 |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#47289