Merged
Conversation
jrieken
reviewed
Jun 25, 2018
|
|
||
| /** | ||
| * Registers a [Uri handler](#UriHandler) capable of handling system-wide [Uris](#Uri). | ||
| * In case there are multiple windows open, the topmost window will handle the Uri. |
Member
There was a problem hiding this comment.
use lower-case uri for consistency
| * | ||
| * For example, if the `vscode.git` extension registers a Uri handler, it will only | ||
| * be allowed to handle Uris with the prefix `{scheme}://vscode.git`, in which `{scheme}` | ||
| * is either `vscode` or `vscode-insiders`. All the following Uris are examples: |
Member
There was a problem hiding this comment.
This is tricky, we don't use product-names in the documentation. I usually use 'the editor' but something better is needed for those samples.
Also, add some clarity or familiar uri-terms, like: The uri-scheme must be the product name, the uri-authority must be the extension id, the path, query, and fragment can be chosen freely.
Member
Author
|
Pushed updates. |
Member
Author
|
Let's try to remove branding from the documentation. |
Member
Author
|
@jrieken Removed product specific language from the docs. Up for final review. |
jrieken
reviewed
Jul 6, 2018
| * | ||
| * Extensions that support reviving should have an `"onWebviewPanel:viewType"` activation event and | ||
| * make sure that [registerWebviewPanelSerializer](#registerWebviewPanelSerializer) is called during activation. | ||
| * Extensions that support reviving should have an`"onWebviewPanel:viewType"` activation event and |
Member
|
Seems to have an accidental change but apart from that 🚢 it. |
Member
Author
|
Good catch. I used the git merge ui for the first time. 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made the following changes as discussed in the API call:
UriHandlerhandleUrinow returnsProviderResult<void>and we log errors, if any