Use events instead of PPromise for search IPC#53536
Merged
joaomoreno merged 3 commits intomasterfrom Jul 9, 2018
Merged
Conversation
joaomoreno
added
debt
roblourens
reviewed
Jul 8, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thanks! LGTM. I assume I'm responsible for extHostSearch.ts and everything internal to search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm removing PPromise support from the IPC layer. This removes the usage of PPromise in Search's IPC layer and replaces it with events.
We still need to remove Search's use of PPromise... but it'll have to come later.