Skip to content

Settings: Fix aria labels using role=form. Fixes: #54836#57314

Merged
cleidigh merged 1 commit intomicrosoft:masterfrom
cleidigh:settings-labels/tweak2
Aug 28, 2018
Merged

Settings: Fix aria labels using role=form. Fixes: #54836#57314
cleidigh merged 1 commit intomicrosoft:masterfrom
cleidigh:settings-labels/tweak2

Conversation

@cleidigh
Copy link
Copy Markdown
Contributor

  • Changes tree widget instance for settings to use role=form
  • Provides correct labeling order
  • Adds describedby for settings description

Replaces PR: #57127

@cleidigh cleidigh requested a review from roblourens August 28, 2018 03:40
@cleidigh cleidigh self-assigned this Aug 28, 2018
@cleidigh cleidigh added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Aug 28, 2018
@cleidigh cleidigh added this to the August 2018 milestone Aug 28, 2018
@cleidigh cleidigh merged commit d2e16e5 into microsoft:master Aug 28, 2018
@roblourens
Copy link
Copy Markdown
Member

Thanks! 🎉

@cleidigh
Copy link
Copy Markdown
Contributor Author

@roblourens
good stuff!
I will add the enum descriptions next

@cleidigh cleidigh deleted the settings-labels/tweak2 branch October 22, 2018 00:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants