Allow TerminalOptions.cwd to be a URI or a string#64461
Merged
Conversation
kieferrm
changed the title
Tyriar
reviewed
Dec 6, 2018
| export function getCwd(shell: IShellLaunchConfig, root: Uri, customCwd: string): string { | ||
| if (shell.cwd) { | ||
| return shell.cwd; | ||
| return (typeof shell.cwd === 'object') ? shell.cwd.path : shell.cwd; |
Contributor
There was a problem hiding this comment.
I tested it on mac and it seems like this is the one we want.
Tyriar
approved these changes
Dec 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an extension to override the authority of the workspace/window when a terminal is created.
@Tyriar I'm not sure if the path needs to be treated here in any way after is has been extracted from the URI.