Fixes #6938: Integrated terminal non-falsey shell exit codes should be reported to the UI, not just the console#8770
Conversation
|
@chrmarti, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Tyriar and @kisstkondoros to be potential reviewers |
|
Hi @chrmarti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
There was a problem hiding this comment.
I don't think Terminal: is necessary here, doesn't seem to be used elsewhere (from a cursory search of Severity.Error).
|
Generally good practice to keep first line of git commit messages under 50 characters, more detail underneath (for future ref 😃). |
Integrated terminal non-falsey shell exit codes should be reported to the UI, not just the console
Replacing console.error with the regular error message.