Skip to content

Fixes #6938: Integrated terminal non-falsey shell exit codes should be reported to the UI, not just the console#8770

Merged
chrmarti merged 1 commit intomicrosoft:masterfrom
chrmarti:master
Jul 5, 2016
Merged

Fixes #6938: Integrated terminal non-falsey shell exit codes should be reported to the UI, not just the console#8770
chrmarti merged 1 commit intomicrosoft:masterfrom
chrmarti:master

Conversation

@chrmarti
Copy link
Copy Markdown
Collaborator

@chrmarti chrmarti commented Jul 5, 2016

Replacing console.error with the regular error message.

@mention-bot
Copy link
Copy Markdown

@chrmarti, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Tyriar and @kisstkondoros to be potential reviewers

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 5, 2016

Hi @chrmarti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Christof Marti). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Terminal: is necessary here, doesn't seem to be used elsewhere (from a cursory search of Severity.Error).

@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Jul 5, 2016

Generally good practice to keep first line of git commit messages under 50 characters, more detail underneath (for future ref 😃).

Integrated terminal non-falsey shell exit codes should be reported to the UI, not just the console
@chrmarti chrmarti merged commit 6884052 into microsoft:master Jul 5, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants