Only treat diff editors as matching if they have the same value for 'forceOpenABinaryEditor'#88183
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jan 7, 2020
Merged
Conversation
…Binary setting Fixes microsoft#88166 Custom editors used in diff views for binary files were broken. The root cause we were creating a `DiffEditorInput` that set `forceOpenAsBinary === true`, however this input was discarded as it was judged to be the same as the existing editor input which had `forceOpenAsBinary === undefined` The fix here is to make the `matches` function take `forceOpenAsBinary` into account
bpasero
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88166
Custom editors used in diff views for binary files were broken. The root cause we were creating a
DiffEditorInputthat setforceOpenAsBinary === true, however this input was discarded as it was judged to be the same as the existing editor input which hadforceOpenAsBinary === undefinedTo fix this, I've updated the
matchesfunction so that it also considersforceOpenAsBinary