Build just once when tfms run in parallel#15465
Merged
nohwnd merged 2 commits intomicrosoft:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents parallel dotnet test runs (across TFMs) from rebuilding/patching the same test assets concurrently by introducing a named mutex guarding the one-time build/setup work.
Changes:
- Added a named
Mutexto serialize build/setup across parallel test runs within the same repo clone. - Moved build/setup steps (unzip, cache cleanup, asset builds, dotnet patching) behind the mutex.
- Added a timeout path for waiting test runs.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Build.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Build.cs
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Mar 10, 2026
Youssef1313
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running dotnet test would trigger build of assets from two places at the same time, which does more work, and also fails occasionally when they run into each other.
Related issue
Fix #15453