Merged
Conversation
Member
Author
|
only affects internal pipeline |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build script’s test-runner argument composition to address CI test filtering/parameter passing.
Changes:
- Splits filter construction from
--ignore-exit-code 8handling into separate variables. - Passes the composed external arguments via
/p:TestRunnerExternalArguments=....
Comments suppressed due to low confidence (2)
eng/build.ps1:1
$filterParametersis only set when$filters.Count -gt 0, but this block also runs when only$testParameters.Count -gt 0. In that case line 141 references an uninitialized variable, producing an empty/incorrectTestRunnerExternalArgumentsvalue or an error under strict settings. Initialize$filterParametersto an empty string before the innerif, or buildTestRunnerExternalArgumentsby conditionally appending the filter part only when filters exist.
[CmdletBinding(PositionalBinding = $false)]
eng/build.ps1:1
- The comment mentions escaping via
\\\", but the code uses PowerShell’s backtick-escape (`\"). Update the comment to match the actual escaping mechanism to avoid confusion during future maintenance.
[CmdletBinding(PositionalBinding = $false)]
| @@ -125,15 +125,20 @@ if ($integrationTest -or $performanceTest -or $compatibilityTest -or $smokeTest) | |||
| } | |||
|
|
|||
| if ($filters.Count -gt 0 -or $testParameters.Count -gt 0) { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.