Add progress indicators for OCI component downloads#515
Merged
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add progress display for loading wassette component
Add progress indicators for OCI component downloads
Nov 10, 2025
Mossaka
requested changes
Nov 11, 2025
crates/wassette/src/lib.rs
Outdated
| loader::load_resource::<ComponentResource>(uri, &self.oci_client, &self.http_client) | ||
| .await?; | ||
| // Show progress when running in CLI mode (stderr is a TTY) | ||
| use std::io::IsTerminal; |
Contributor
Author
There was a problem hiding this comment.
Moved use std::io::IsTerminal to line 9 with other std imports in commit 1874a68.
…nality Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Contributor
Author
Mossaka
added a commit
to Mossaka/wassette
that referenced
this pull request
Feb 2, 2026
* Initial plan * Add progress indicators for OCI component downloads Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * Apply rustfmt formatting Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * Move IsTerminal import to top and add unit tests for progress functionality Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add progress indicators for OCI component downloads
Successfully implemented progress indicators for
wassette component load oci://command.Changes Made
Modified Files:
crates/wassette/src/oci_multi_layer.rspull_multi_layer_artifact_with_progress()function withshow_progressparametercrates/wassette/src/loader.rsfrom_oci_reference_with_progress()trait methodload_resource_with_progress()functioncrates/wassette/src/lib.rsuse std::io::IsTerminalto top imports (line 9)Unit Tests Added (5 total)
loader.rs tests:
test_load_resource_with_progress_api_exists- Verifies progress API function existstest_component_resource_has_progress_method- Verifies ComponentResource implements progress methodtest_policy_resource_has_progress_method- Verifies PolicyResource implements progress methodoci_multi_layer.rs tests:
test_pull_multi_layer_artifact_with_progress_exists- Verifies progress function existstest_pull_multi_layer_artifact_calls_progress_version- Verifies delegation to progress versionTesting
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.