Skip to content

Apply timeout configuration to waza run#130

Merged
github-actions[bot] merged 1 commit intomicrosoft:mainfrom
chlowell:timeout
Mar 17, 2026
Merged

Apply timeout configuration to waza run#130
github-actions[bot] merged 1 commit intomicrosoft:mainfrom
chlowell:timeout

Conversation

@chlowell
Copy link
Member

Users set a timeout value in eval configuration and commands like run pass that to CopilotEngine.Execute() via ExecutionRequest.Timeout. The value stops there. It's never realized as a Context timeout, so these commands get the Copilot SDK's default timeout instead. This PR is a quick fix; really the cancellation API needs a refactor (#129)

Copilot AI review requested due to automatic review settings March 16, 2026 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enforce ExecutionRequest.Timeout for Copilot executions by adding a context deadline inside CopilotEngine.Execute when the incoming context has no deadline.

Changes:

  • Wrap ctx in context.WithTimeout(ctx, req.Timeout) when ctx has no deadline.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3068653). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   73.52%           
=======================================
  Files           ?      138           
  Lines           ?    15789           
  Branches        ?        0           
=======================================
  Hits            ?    11609           
  Misses          ?     3338           
  Partials        ?      842           
Flag Coverage Δ
go-implementation 73.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlowell chlowell marked this pull request as ready for review March 16, 2026 17:26
@github-actions github-actions bot enabled auto-merge (squash) March 16, 2026 17:26
@github-actions github-actions bot merged commit b07221f into microsoft:main Mar 17, 2026
11 of 12 checks passed
@chlowell chlowell deleted the timeout branch March 17, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants