Apply timeout configuration to waza run#130
Merged
github-actions[bot] merged 1 commit intomicrosoft:mainfrom Mar 17, 2026
Merged
Apply timeout configuration to waza run#130github-actions[bot] merged 1 commit intomicrosoft:mainfrom
waza run#130github-actions[bot] merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to enforce ExecutionRequest.Timeout for Copilot executions by adding a context deadline inside CopilotEngine.Execute when the incoming context has no deadline.
Changes:
- Wrap
ctxincontext.WithTimeout(ctx, req.Timeout)whenctxhas no deadline.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage ? 73.52%
=======================================
Files ? 138
Lines ? 15789
Branches ? 0
=======================================
Hits ? 11609
Misses ? 3338
Partials ? 842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richardpark-msft
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users set a timeout value in eval configuration and commands like
runpass that toCopilotEngine.Execute()viaExecutionRequest.Timeout. The value stops there. It's never realized as a Context timeout, so these commands get the Copilot SDK's default timeout instead. This PR is a quick fix; really the cancellation API needs a refactor (#129)