Fix GraderConfig.UnmarshalYAML to reject unknown fields at grader entry level#150
Closed
Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
Closed
Fix GraderConfig.UnmarshalYAML to reject unknown fields at grader entry level#150Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
Conversation
Co-authored-by: LarryOsterman <8220172+LarryOsterman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on YAML input validation and tests in original PR
Fix GraderConfig.UnmarshalYAML to reject unknown fields at grader entry level
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadBenchmarkSpecsetsKnownFields(true)on the top-level decoder, butGraderConfig.UnmarshalYAMLwas callingnode.Decode(&raw)which doesn't inherit that setting — unknown keys alongsidetype,name,weight, etc. were silently accepted.Changes
internal/models/spec.go: ChangedGraderConfig.UnmarshalYAMLto marshal the node back to bytes and re-decode with an explicityaml.NewDecoder+KnownFields(true), matching the pattern already used bydecodeYAMLNodefor theconfig:sub-object.internal/models/spec_test.go: Added two new cases toTestLoadBenchmarkSpec_StrictYAML— one for an unknown field at the grader entry level and one for an unknown field insideconfig:.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.