fix: update EvalGet test fixture for code grader validation#197
Merged
Conversation
spboyer
requested review from
chlowell,
richardpark-msft and
wbreza
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the eval.get JSON-RPC handler test fixture to satisfy the newer grader-config validation added in PR #195 by providing required config.assertions for a type: code grader.
Changes:
- Add
config.assertionsto thetype: codegrader inTestHandler_EvalGet_Successfixture YAML.
Show a summary per file
| File | Description |
|---|---|
| internal/jsonrpc/handlers_test.go | Updates eval.yaml test fixture to include required code-grader config assertions so spec loading/validation succeeds. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Replace placeholder assertion with 'len(output) > 0' which is valid Python syntax for the inline script grader eval_wrapper.py. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
force-pushed
the
fix/coverage-test-fixtures-grader-config
branch
from
de9303b to
e996290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #195. The TestHandler_EvalGet_Success fixture had a code grader without config. Added config.assertions to satisfy the new validation.