fix: webserver test skips when frontend assets not built

[spboyer]

Problem

TestIndexHTMLReferencesExistingAssets fails on Windows CI because npm run build only runs on the ubuntu-latest matrix. The test's skip guard only checked whether the assets/ directory existed — not whether it contained actual JS/CSS bundles. If the directory exists but is empty (cache artefact, partial build), the test proceeds and fails when the SPA fallback serves index.html instead of the expected asset content types.

Fix

After confirming assets/ exists, the test now also verifies it contains at least one .js or .css file. If not, it skips with a descriptive message pointing at npm run build.

Verification

• go test -count=1 -v ./internal/webserver/... — all pass
• go test ./... — full suite green
• go vet ./... — clean

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[Copilot]

Pull request overview

Fixes Windows CI flakiness in internal/webserver by making the TestIndexHTMLReferencesExistingAssets skip guard verify that frontend bundles are actually present, not just that the assets/ directory exists.

Changes:

• Read dist/assets directory entries and fail fast on unexpected FS errors.
• Skip TestIndexHTMLReferencesExistingAssets when dist/assets exists but contains no .js/.css bundles, with a message pointing to npm run build.

Show a summary per file

File	Description
internal/webserver/server_test.go	Strengthens the test precondition for embedded frontend assets to avoid false failures when assets aren’t built.

Copilot's findings

Comments suppressed due to low confidence (1)

internal/webserver/server_test.go:186

• The skip check only requires either a .js or .css file. If a partial/cached build leaves just one of those (or only non-bundle files), this test will still run and then fail later when a referenced asset is missing and served by the SPA fallback. Since index.html references both JS and CSS bundles, consider tracking hasJS and hasCSS (similar to TestEmbeddedAssetsDirectoryContainsBundles) and skipping unless both are present.

	var hasBundles bool
	for _, e := range entries {
		if !e.IsDir() {
			ext := filepath.Ext(e.Name())
			if ext == ".js" || ext == ".css" {
				hasBundles = true

• Files reviewed: 1/1 changed files
• Comments generated: 1