feat: allow specifying skill_directories per task (#156)#215
Merged
Conversation
Add SkillPaths field to TestCase struct so tasks can override eval-level skill_directories. Task-level paths replace (not merge with) eval-level paths. If not specified, falls back to eval-level. Changes: - Add SkillPaths []string to TestCase (yaml: skill_directories) - Update buildExecutionRequest() to prefer task-level skill paths - Add model-level test (TestLoadTestCase_SkillDirectories) - Add runner-level test (TestBuildExecutionRequest_TaskLevelSkillPaths) - Update task.schema.json with skill_directories property - Update eval-yaml guide and schema reference docs Closes #156 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
skill_directoriesto be specified per-task in eval YAML files, overriding the eval-level setting. This enables tasks that need different skills from the rest of the eval.Changes
internal/models/testcase.go: AddSkillPaths []stringfield toTestCasestruct (yaml:"skill_directories")internal/orchestration/runner.go: UpdatebuildExecutionRequest()to prefer task-levelSkillPathsover eval-level, falling back when unsetinternal/models/testcase_test.go: AddTestLoadTestCase_SkillDirectories— verifies YAML parsing of the new fieldinternal/orchestration/runner_test.go: AddTestBuildExecutionRequest_TaskLevelSkillPaths— verifies override and fallback logicschemas/task.schema.json: Addskill_directoriesarray propertysite/src/content/docs/guides/eval-yaml.mdx: Addskill_directoriesto Task Fields tablesite/src/content/docs/reference/schema.mdx: Addskill_directoriessection to Task File FormatBehavior
skill_directoriesreplaces (not merges with) eval-level pathsskill_directories, falls back to eval-levelExample
Closes #156
Working as Linus (Backend Developer)