Fix custom-agent eval example schema#282
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the checked-in examples/custom-agent eval suite to match the current eval/task JSON schemas, and adds a regression test to ensure the example remains schema-valid as the schemas evolve.
Changes:
- Add a schema regression test that validates
examples/custom-agent/eval.yamland its referenced task files. - Update the custom-agent example
eval.yamlto include required top-level fields (skill,version,metrics) and the current prompt-grader config shape. - Rewrite the example task YAMLs to the current task schema, including attaching fixture files via
inputs.files.
Show a summary per file
| File | Description |
|---|---|
| internal/validation/schema_test.go | Adds a regression test to validate the checked-in custom-agent example against the current schemas. |
| examples/custom-agent/eval.yaml | Updates eval spec to current schema (required fields + grader config shape). |
| examples/custom-agent/tasks/review-clean-code.yaml | Migrates task to current task schema and attaches fixture file input. |
| examples/custom-agent/tasks/find-xss.yaml | Migrates task to current task schema and attaches fixture file input. |
| examples/custom-agent/tasks/find-sql-injection.yaml | Migrates task to current task schema and attaches fixture file input. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the checked-in custom-agent example so it matches the current eval and task schemas and can be copy/paste run with the current CLI.
Validation:
go test ./...Docs impact: none beyond the example and schema regression coverage.
Closes #274