Add skill body injection opt-out#292
Merged
github-actions[bot] merged 1 commit intoMay 23, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new evaluation config flag to opt out of injecting the full target skill/agent body into the system prompt, enabling “trigger-precision” evals to measure actual skill tool invocation while preserving skill association and discovery behavior.
Changes:
- Introduces
config.inject_skill_body(defaulttrue) and threads it through eval orchestration andwaza triggerviaExecutionRequest.SuppressSkillBody. - Updates Copilot SDK execution prompt construction to conditionally omit the target
<skill_context>while keeping<available_skills>summaries. - Updates JSON schema + docs, and adds/extends unit tests across schema validation, spec parsing, orchestration/trigger runners, and skill message building.
Show a summary per file
| File | Description |
|---|---|
| site/src/content/docs/reference/schema.mdx | Documents the new inject_skill_body config field and its trigger-precision use case. |
| site/src/content/docs/guides/eval-yaml.mdx | Adds inject_skill_body to config examples/table and documents trigger-precision guidance. |
| schemas/eval.schema.json | Extends eval JSON schema to allow config.inject_skill_body with default true. |
| README.md | Documents how to disable target skill body injection for trigger-precision evals. |
| internal/validation/schema_test.go | Adds schema validation coverage for inject_skill_body. |
| internal/trigger/runner.go | Propagates config into execution via SuppressSkillBody. |
| internal/trigger/runner_test.go | Verifies SuppressSkillBody is set when opting out. |
| internal/orchestration/runner.go | Propagates config into execution requests via SuppressSkillBody. |
| internal/orchestration/runner_test.go | Adds request-building coverage for default vs suppressed injection. |
| internal/models/spec.go | Adds InjectSkillBody *bool and ShouldInjectSkillBody() defaulting logic. |
| internal/models/spec_test.go | Tests defaulting + YAML deserialization of inject_skill_body. |
| internal/execution/skill_injection_test.go | Adds unit test ensuring target <skill_context> is omitted when suppressed. |
| internal/execution/engine.go | Extends ExecutionRequest with SuppressSkillBody. |
| internal/execution/copilot.go | Threads suppression into buildSkillSystemMessage(..., injectSkillBody) behavior. |
| internal/execution/copilot_test.go | Updates tests to match the new buildSkillSystemMessage signature. |
Copilot's findings
- Files reviewed: 15/15 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger-precision evals need to measure whether an agent invokes a skill, but the existing
skill:path injected the full target skill body into the system prompt. This adds an explicit opt-out so evals can keep their skill association while requiring the agent to use theskilltool for the body.Summary
config.inject_skill_body, defaulting to true to preserve existing behavior.waza triggersofalsesuppresses only the target<skill_context>block.<available_skills>summaries active unless skills are fully disabled.Testing
go test ./...cd site && npm ci --silent && npm run buildNotes
This task was flagged as "needs review" because it touches medium-complexity CLI/execution behavior. Please have a squad member review before merging.
Fixes: #285