feat: invert token limits priority to .waza.yaml first #59

[wbreza]

Closes #59
Part of #20

What changed

• resolveLimitsConfig() now checks .waza.yaml tokens.limits first
• .token-limits.json is legacy fallback only
• Deprecation warning when .token-limits.json is the active source
• Updated both call sites (check.go, suggest.go) for new return signature

Testing

• 8 new tests covering all 4 scenarios (waza-only, legacy-only, both, neither)
• Existing TestCheck_ConfigLimits and TestCheck_DefaultLimitsWhenNoConfig pass
• go test ./... green

[Copilot]

Pull request overview

This PR updates token limits configuration precedence to support the ongoing config consolidation work: .waza.yaml tokens.limits is now the primary source, with .token-limits.json treated as a legacy fallback and accompanied by a deprecation warning when used.

Changes:

• Inverted resolveLimitsConfig() precedence to prefer .waza.yaml tokens.limits, falling back to .token-limits.json, then built-in defaults.
• Updated check and suggest flows to handle the new (cfg, usedLegacy) return and emit a deprecation warning when legacy config is active.
• Added unit + integration tests and new fixtures for .waza.yaml limits and “both present” precedence.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
cmd/waza/tokens/helpers.go	Changes limits resolution order and returns a legacy-usage flag.
cmd/waza/tokens/check.go	Uses new helper return signature; emits legacy deprecation warning.
cmd/waza/tokens/suggest.go	Uses new helper return signature; emits legacy deprecation warning.
cmd/waza/tokens/helpers_test.go	Adds unit tests for precedence scenarios.
cmd/waza/tokens/check_test.go	Adds integration tests validating .waza.yaml precedence in check.
cmd/waza/tokens/testdata/check/waza-yaml-limits/*	New fixtures for .waza.yaml-based limits.
cmd/waza/tokens/testdata/check/both-configs/*	New fixtures for “both configs present; .waza.yaml wins”.
.squad/agents/linus/history.md	Documents the change and testing summary.

[wbreza]

Rusty architecture review summary:

• Priority is correctly inverted (.waza.yaml first, .token-limits.json fallback, defaults last).
• Deprecation warning text is clear and actionable.
• (cfg, usedLegacy) is the right signature; warning emission belongs at call sites and both check/suggest are wired correctly.
• Coverage includes all 4 source-resolution scenarios and preserves legacy-only behavior.

I cannot submit an approve review on this PR because GitHub blocks approving your own pull request, but this is architecturally good to merge.

[richardpark-msft]

@copilot, are there any relevant spots to add documentation for this? I think users will need to know how all the configs and overrides intersect.

[Copilot]

@richardpark-msft I've opened a new pull request, #70, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

site/src/content/docs/guides/token-limits.mdx:57

• This section says fallbackLimit is “Limit applied to files that match no pattern”, but token limit fallback for waza tokens check/suggest is currently hard-coded to 2000 via internal/checks.FallbackLimit, and .waza.yaml tokens.fallbackLimit isn’t used in the token limits checker. Please clarify what fallbackLimit actually affects today (or implement support for it).

| Field | Type | Default | Description |
|-------|------|---------|-------------|
| `warningThreshold` | integer | `2500` | Token count at which a soft warning is shown |
| `fallbackLimit` | integer | `1000` | Limit for files that match no pattern |
| `limits.defaults` | map | (built-in) | Glob patterns → token limits |
| `limits.overrides` | map | `{}` | Exact file paths → token limits (take precedence over `defaults`) |

Both `limits.defaults` and `limits.overrides` are optional — you can set only one of them. If `tokens.limits` is present in `.waza.yaml` but neither map is set, `.token-limits.json` is **not** consulted as a fallback; `.waza.yaml` is the definitive source.

[spboyer]

Rusty (Opus 4.6) — Lint Still Failing

Last commit: \ix: gofmt helpers.go\ (March 4) — but the Lint check is still ❌. Tests pass on both ubuntu and windows, but golangci-lint fails.

Action needed: Run \golangci-lint run\ locally, fix the remaining lint issue, and push.

[spboyer]

Fixed lint errors and rebased on main.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.