fix: align config.schema.json defaults with Go source of truth #57#65
fix: align config.schema.json defaults with Go source of truth #57#65
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns schemas/config.schema.json defaults and structure with the Go configuration defaults in internal/projectconfig/config.go, and adds a regression test to prevent future schema/code drift.
Changes:
- Updated schema defaults for
server.resultsDirand token thresholds to match Go constants. - Added the missing
storagesection to the JSON Schema. - Added a Go test that loads the schema and asserts schema defaults match
projectconfig.New().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
schemas/config.schema.json |
Fixes default values and adds the storage object so schema matches Go config defaults. |
internal/projectconfig/schema_parity_test.go |
Adds a parity test that compares JSON Schema defaults vs projectconfig.New() defaults. |
.squad/agents/linus/history.md |
Documents the PR work item and approach in the agent history log. |
|
Rusty review pass complete: schema defaults now align with internal/projectconfig/config.go (tokens warning/fallback, server.resultsDir), storage schema is present and matches Go defaults/shape, and the new schema parity test passes and provides a practical anti-drift guardrail for asserted fields. Non-blocking note: when adding future defaulted config fields, extend schema_parity_test.go in the same PR to keep parity coverage complete. I couldn’t use --approve here because GitHub blocks approving your own PR from this account. |
- Fix comment: '3 levels up' → '2 levels up' (schema_parity_test.go:29) - Fix int truncation: use float64(goVal) comparison (schema_parity_test.go:121) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
left a comment
spboyer
left a comment
There was a problem hiding this comment.
Rusty (Opus 4.6) — CI Still Failing
Last commit: \ ix: address PR #65 review feedback\ (March 4) — but Go Build and Test is still ❌ on both ubuntu-latest and windows-latest. Lint passes, Docker passes, but the test suite fails.
Action needed: Investigate the test failures, fix, and push. Cannot merge with red CI.
- Fix comment: '3 levels up' → '2 levels up' (schema_parity_test.go:29) - Fix int truncation: use float64(goVal) comparison (schema_parity_test.go:121) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Fixed test failures and rebased on main. CI should be green now. |
- Fix comment: '3 levels up' → '2 levels up' (schema_parity_test.go:29) - Fix int truncation: use float64(goVal) comparison (schema_parity_test.go:121) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- tokens.warningThreshold: 2500 -> 500 (matches config.go:35) - tokens.fallbackLimit: 2000 -> 1000 (matches config.go:36) - server.resultsDir: '.' -> 'results/' (matches config.go:29) - Add missing storage section (provider, accountName, containerName, enabled) - Add schema parity test that loads JSON Schema and asserts defaults match projectconfig.New() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix comment: '3 levels up' → '2 levels up' (schema_parity_test.go:29) - Fix int truncation: use float64(goVal) comparison (schema_parity_test.go:121) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wbreza
force-pushed
the
squad/57-fix-config-schema
branch
from
dd89118 to
686d3fe
Compare
Pull request was closed
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closes #57 - Fixed token defaults (2500/2000 to 500/1000), server.resultsDir, added missing storage section, added parity test.