chore: add code-review skill and strengthen existing skills#104
Merged
mohamedmansour merged 1 commit intomainfrom Mar 14, 2026
Merged
chore: add code-review skill and strengthen existing skills#104mohamedmansour merged 1 commit intomainfrom
mohamedmansour merged 1 commit intomainfrom
Conversation
Create a dedicated code-review skill with 10-section framework review checklist covering correctness, performance, concurrency, design, and style. Derived from a full-project audit (63 findings across 12 crates and 2 TS packages) that exposed coverage gaps in existing guidance. Changes: - Add .github/skills/code-review/SKILL.md (288 lines, 10 sections) - Update handler-perf skill with 5 new hot-path rules (String::from(ch), template caching, hex parsing, silent unwrap_or, clone discipline) - Update FFI skill with explicit catch_unwind requirement and no unwrap/expect rule for panic safety across the boundary - Replace misplaced engineering checklist in PR skill with a cross-reference to the new code-review skill - Register code-review skill in copilot-instructions.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mohamedmansour
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a dedicated code-review skill and strengthen three existing skills (handler-perf, FFI, PR) based on findings from a full-project audit that produced 63 issues across all 12 Rust crates and 2 TypeScript packages.
The existing skills had a 30% catch rate — these changes close the gaps so the same classes of issues are flagged before PRs are opened.
Changes
New:
.github/skills/code-review/SKILL.md10-section framework code review checklist:
catch_unwindon FFI, WASM panic hooks, callback error propagation, file watcher recovery, cache write races, Node event loop blocking#[must_use], silent fallbacks, error precision, byte/char confusion, numeric precision, build-time validation, UTF-8 safetyUpdated:
.github/skills/handler-perf/SKILL.mdAdded 5 rules from handler audit:
String::from(ch)in escape loops — useencode_utf8as_str()format!in hex parsing — direct arithmeticunwrap_ordefaults — propagate errorsUpdated:
.github/skills/ffi/SKILL.mdExpanded panic safety rules:
catch_unwindrequirement on all FFI function bodiesunwrap()/expect()in any FFI code path (including helpers)Updated:
.github/skills/pr/SKILL.mdUpdated:
.github/copilot-instructions.md