fix(handler): skip CSS link tags for components without stylesheets#178
Merged
mohamedmansour merged 2 commits intomainfrom Apr 6, 2026
Merged
fix(handler): skip CSS link tags for components without stylesheets#178mohamedmansour merged 2 commits intomainfrom
mohamedmansour merged 2 commits intomainfrom
Conversation
The handler's head_end signal emitted <link rel="stylesheet"> tags for every component on the route, regardless of whether the component had a CSS file. Components like cb-page-group (no .css sibling) got phantom links that 404'd in the browser. Root cause: the handler iterated needed_components and unconditionally wrote a <link> tag using the component name as the href. No check for CSS existence. Fix: add a css_href field to ComponentData in the protocol. The builder sets it only for Link-strategy components in Light DOM mode that have a CSS file. Shadow DOM components embed their own <link> inside the shadow root template at parse time, so they don't need head links. Style and Module strategies never produce external CSS files. The handler now emits <link> tags only when css_href is non-empty, using the exact href from the protocol rather than constructing it from the component name. Also consolidated three separate css_snapshot loops in the builder into a single pass with early-exit branches per strategy — Style strategy now does zero allocations in the CSS processing loop. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akroshg
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler's head_end signal emitted tags for every component on the route, regardless of whether the component had a CSS file. Components like cb-page-group (no .css sibling) got phantom links that 404'd in the browser.
Root cause: the handler iterated needed_components and unconditionally wrote a tag using the component name as the href. No check for CSS existence.
Fix: add a css_href field to ComponentData in the protocol. The builder sets it only for Link-strategy components in Light DOM mode that have a CSS file. Shadow DOM components embed their own inside the shadow root template at parse time, so they don't need head links. Style and Module strategies never produce external CSS files.
The handler now emits tags only when css_href is non-empty, using the exact href from the protocol rather than constructing it from the component name.
Also consolidated three separate css_snapshot loops in the builder into a single pass with early-exit branches per strategy — Style strategy now does zero allocations in the CSS processing loop.