fix(handler): emit all reachable components on current node#226
Merged
mohamedmansour merged 1 commit intomainfrom Apr 13, 2026
Merged
fix(handler): emit all reachable components on current node#226mohamedmansour merged 1 commit intomainfrom
mohamedmansour merged 1 commit intomainfrom
Conversation
mohamedmansour
requested review from
a team,
akroshg,
mcritzjam and
toddreifsteck
mohamedmansour
changed the title
mohamedmansour
force-pushed
the
fix/conditional-components
branch
from
ea22c92 to
4c34e5d
Compare
mohamedmansour
force-pushed
the
fix/conditional-components
branch
from
4c34e5d to
364e4e8
Compare
janechu
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was too conservative regarding rendered components, and we didn't have any example which used components within empty for loops or falsey conditions. Now we emit reachable components