docs: cleanup plugin wordings#282
Merged
Merged
Conversation
@attr is documented as bidirectional reflection ("reflects to/from an HTML attribute"), but only the attribute → property direction was implemented via attributeChangedCallback. Property mutations never reached the DOM, so selectors like `calc-app[mode="scientific"]` silently broke after client-side state changes — the calculator E2E tests added in PR #282 caught this. Inline the reflection in the @attr setter so that when the element is connected, every property mutation also writes the attribute (boolean mode toggles presence; string mode writes `String(value)` or removes when nullish). The pre-flight `getAttribute`/`hasAttribute` check keeps SSR-upgraded elements paying only one comparison, and the synchronous `attributeChangedCallback` re-entry short-circuits on the `oldValue === newValue` guard. Defining the setter directly inside applyAttr (instead of routing through createReactiveProperty with a reflect callback) avoids one closure allocation per @attr declaration and one indirect call per setter invocation. Folding the previous attrMap + boolAttrs registries into a single attrMeta map cuts the ACB from two WeakMap lookups to one. class-field initializers don't "gain attributes" inside the constructor (forbidden by the custom-element spec). Detached property writes won't reflect to the attribute until the next setter call while connected — no example app uses that pattern, and a connect-time reconciliation pass can be reintroduced cheaply if needed. Adds attr fixture coverage for property → attribute reflection, nullish removal, and boolean toggling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tribute" This reverts commit 27afcba.
akroshg
previously approved these changes
Apr 30, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mohamedmansour
force-pushed
the
feat/cleanup-docs
branch
from
4dc83de to
69886e2
Compare
akroshg
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #279 (split FAST → fast-v2, added fast-v3) leaked FAST-specific names, marker tables, and code paths into places that are supposed to be plugin-agnostic. The repo started reading "FAST-first" even though FAST is just one of several plugins. We should be generic.
What we did
longer enumerate FAST plugin variants or wire formats. They describe the plugin architecture neutrally and link to the dedicated WebUI Framework spec for one concrete
example.
What we deliberately left alone
Validation