feat: Support custom protocol filename via --out=path.bin#314
Merged
Conversation
Closed
Copilot
AI
changed the title
[WIP] Add option to specify custom protocol output filename
Allow customizing the protocol filename via May 27, 2026
webui build --out
mohamedmansour
approved these changes
May 27, 2026
mohamedmansour
changed the title
webui build --outwebui build --out
There was a problem hiding this comment.
Pull request overview
This PR updates the webui build --out CLI behavior to support specifying either an output directory (existing behavior) or a .bin file path to customize the emitted protocol filename, enabling multiple apps to be built into a shared output folder without manual renames.
Changes:
- Added CLI-side
--outresolution logic to split a.binfilepath into(output_dir, protocol_filename)and write protocol + CSS files accordingly. - Added unit and end-to-end tests covering custom protocol filenames and parent directory creation.
- Updated CLI documentation to describe the dual-form
--outoption and provide examples.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/guide/cli/index.md | Documents that --out accepts a directory or .bin filepath and adds examples. |
| crates/webui-ffi/include/webui_ffi.h | Refines thread-safety wording in FFI header comments. |
| crates/webui-cli/src/commands/build.rs | Implements .bin-path handling and manual protocol/CSS writes; adds tests. |
| crates/webui-cli/README.md | Documents the new --out behavior and adds an example invocation. |
| Cargo.lock | Updates workspace crate versions to 0.0.13. |
Copilot
AI
changed the title
feat: Allow customizing the protocol filename via
Allow customizing the protocol filename via May 27, 2026
webui build --outwebui build --out
mohamedmansour
changed the title
webui build --outwebui build --out
mohamedmansour
approved these changes
May 27, 2026
mcritzjam
previously approved these changes
May 27, 2026
…ol-output-filename # Conflicts: # crates/webui-cli/README.md
Copilot
AI
changed the title
feat: Allow customizing the protocol filename via
Merge origin/main into branch and resolve README conflict
May 27, 2026
webui build --out
Copilot
AI
changed the title
Merge origin/main into branch and resolve README conflict
Merge main into custom-protocol-output-filename
May 27, 2026
mohamedmansour
changed the title
mohamedmansour
approved these changes
May 27, 2026
Qusic
approved these changes
May 27, 2026
KurtCattiSchmidt
approved these changes
May 27, 2026
Copilot AI
added a commit
that referenced
this pull request
May 27, 2026
Clustered changes since v0.0.13: 1) CSS asset naming + parser pipeline (#313) - Added configurable CSS asset names across parser plugins and runtime integration paths. - Introduced dedicated CSS link handling in the parser with broader coverage in benches/examples. - Updated CLI, Node, Rust, and docs surfaces to expose and document the new behavior. 2) Custom protocol output path in CLI/FFI (#314) - Added support for writing protocol output with --out=<path>.bin in the build command flow. - Updated CLI docs and FFI headers so generated protocol output can be redirected predictably. 3) Release alignment for 0.0.14 - Ran cargo xtask version 0.0.14 to synchronize crate/npm/.NET version metadata. - Regenerated dependency lock state as part of the release bump workflow.
mohamedmansour
pushed a commit
that referenced
this pull request
May 27, 2026
* Progress: ran version bump and release checks * chore(release): summarize 0.0.14 changes Clustered changes since v0.0.13: 1) CSS asset naming + parser pipeline (#313) - Added configurable CSS asset names across parser plugins and runtime integration paths. - Introduced dedicated CSS link handling in the parser with broader coverage in benches/examples. - Updated CLI, Node, Rust, and docs surfaces to expose and document the new behavior. 2) Custom protocol output path in CLI/FFI (#314) - Added support for writing protocol output with --out=<path>.bin in the build command flow. - Updated CLI docs and FFI headers so generated protocol output can be redirected predictably. 3) Release alignment for 0.0.14 - Ran cargo xtask version 0.0.14 to synchronize crate/npm/.NET version metadata. - Regenerated dependency lock state as part of the release bump workflow. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
origin/maininto this branch to pick up the configurable CSS asset naming work (#313) and resolve the resulting conflicts.Changes
crates/webui-cli/README.md): kept both example sets — the--out=./dist/app1.binexample from this branch and the new--css-file-name-template/--css-public-baseexamples frommain.crates/webui-cli/src/commands/build.rs): the two custom-protocol-name tests added by this branch constructAppArgsdirectly, which gained two new required fields onmain. Addedcss_file_name_template: DEFAULT_CSS_FILE_NAME_TEMPLATE.to_string()andcss_public_base: Noneto both initializers, matching the other test sites already updated onmain.No production-code changes; the merge commit is a clean two-parent merge of
ea309abandb02af48.